7499 refactor right drawer to have contextual actions #7954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request refactors the right drawer to implement contextual actions and modifies the context store states to be component-specific. The changes introduce a new mainContextStore concept and add support for contextual actions in various components.
- Introduced
RecordIndexActionMenuandRecordShowActionMenucomponents to handle different action menu contexts - Refactored context store states to use
createComponentStateV2for component-specific state management - Added
ActionMenuTypeto differentiate between 'recordIndex' and 'recordShow' action menus - Implemented
SetMainContextStoreComponentInstanceIdEffectto manage the main context store component instance ID - Updated action menu components to use new context store states and support contextual actions
30 file(s) reviewed, 16 comment(s)
Edit PR Review Bot Settings | Greptile
...les/action-menu/actions/record-actions/components/MultipleRecordsActionMenuEntriesSetter.tsx
Show resolved
Hide resolved
.../src/modules/action-menu/actions/record-actions/components/RecordActionMenuEntriesSetter.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/action-menu/components/ActionMenu.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/action-menu/components/RecordIndexActionMenu.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/action-menu/components/RecordIndexActionMenuBarEntry.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/action-menu/components/RecordShowActionMenuBar.tsx
Show resolved
Hide resolved
...-front/src/modules/context-store/states/contextStoreNumberOfSelectedRecordsComponentState.ts
Show resolved
Hide resolved
...nty-front/src/modules/context-store/states/contexts/ContextStoreComponentInstanceContext.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/context-store/states/mainContextStoreComponentInstanceId.ts
Show resolved
Hide resolved
| @@ -0,0 +1 @@ | |||
| export type ActionMenuType = 'recordIndex' | 'recordShow'; | |||
There was a problem hiding this comment.
why do we need this? I think it's a bit broken from a dependency perspective action-menu is a component that should not have to know about where it's used
| const contextStoreNumberOfSelectedRecords = useRecoilValue( | ||
| contextStoreNumberOfSelectedRecordsState, | ||
| export const RecordActionMenuEntriesSetter = ({ | ||
| actionMenuType, |
There was a problem hiding this comment.
also seems a bit painful to drill down
|
|
||
| // For now, this component is the same as RecordIndexActionMenuBarEntry but they | ||
| // will probably diverge in the future | ||
| export const RecordShowActionMenuBarEntry = ({ |
There was a problem hiding this comment.
where is this bar displayed?
charlesBochet
deleted the
7499-refactor-right-drawer-to-have-contextual-actions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7499
mainContextStorewhich will dictate the available actions inside the command K