bug fix webhook response not sending data to tinybird

[anamarn]

Solves https://github.com/twentyhq/private-issues/issues/118

TLDR

Fix webhook response not sending data to tinybird when the url is not a link.

Changes in Tinybird:

• Add column Success to webhook payload (boolean)
• Changed the parameter WebhookIdRequest to WebhookId in the getWebhooksResponse api point.
• Those changes can be seen in the tinybird workspace twenty_analytics_playground

In order to test

1. Set ANALYTICS_ENABLED to true
2. Set TINYBIRD_INGEST_TOKEN to your token from the workspace twenty_analytics_playground
3. Set TINYBIRD_GENERATE_JWT_TOKEN to the admin kwt token from the workspace twenty_analytics_playground
4. Set TINYBIRD_WORKSPACE_UUID to the UUID of twenty_analytics_playground
5. Create a Webhook in twenty and set wich events it needs to track
6. Run twenty-worker in order to make the webhooks work.
7. Do your tasks in order to populate the data
8. Look at your webhooks in settings>api and webhooks> your webhook and the statistics should be displayed

[greptile-apps]

PR Summary

This pull request addresses a bug in webhook response handling, ensuring proper data transmission to Tinybird for analytics.

• Updated fetchGraphDataOrThrow.ts to use 'webhookId' instead of 'webhookIdRequest' in API calls
• Modified call-webhook.job.ts to include a 'success' boolean field in the analytics payload
• Improved error handling in call-webhook.job.ts to conditionally include status code for failed requests
• These changes enhance webhook analytics data quality and accuracy in Tinybird

_{2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile}

[Weiko]

Left some nit comments but LGTM!

[Weiko]

redundant

[Weiko]

This part seems a bit redundant as well, shouldn't success be dependant on the response status / call failure? The rest seems very similar so I think it could be refactored a bit

[FelixMalfait]

Thank you!