Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to twenty-ui - utilities/animation #7951

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Migrate to twenty-ui - utilities/animation #7951

merged 3 commits into from
Oct 22, 2024

Conversation

gitstart-app[bot]
Copy link
Contributor

@gitstart-app gitstart-app bot commented Oct 22, 2024

This PR was created by GitStart to address the requirements from this ticket: TWNTY-7538.


Description

  • Move animation components to twenty-ui


    Fixes #7538

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR migrates animation components from the twenty-front package to the twenty-ui library, centralizing these utilities for better maintainability and reusability across the project.

  • Updated import statements in multiple files to use 'twenty-ui' instead of local paths for animation components
  • Relocated animation components (e.g., AnimatedContainer, AnimatedEaseIn) to packages/twenty-ui/src/utilities/animation/components/
  • Added new index.ts file in packages/twenty-ui/src/utilities/animation/ to export all animation components
  • Modified packages/twenty-ui/src/utilities/index.ts to include exports for the newly migrated animation components

20 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines +15 to 20
import { useSearchParams } from 'react-router-dom';
import { AnimatedEaseIn } from 'twenty-ui';
import {
useAddUserToWorkspaceMutation,
useAddUserToWorkspaceByInviteTokenMutation,
useAddUserToWorkspaceMutation,
} from '~/generated/graphql';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider grouping related imports together for better organization

Suggested change
import { useSearchParams } from 'react-router-dom';
import { AnimatedEaseIn } from 'twenty-ui';
import {
useAddUserToWorkspaceMutation,
useAddUserToWorkspaceByInviteTokenMutation,
useAddUserToWorkspaceMutation,
} from '~/generated/graphql';
import { useSearchParams } from 'react-router-dom';
import { AnimatedEaseIn } from 'twenty-ui';
import {
useAddUserToWorkspaceByInviteTokenMutation,
useAddUserToWorkspaceMutation,
} from '~/generated/graphql';
import styled from '@emotion/styled';
import { useMemo } from 'react';
import { useRecoilValue } from 'recoil';
import { Logo } from '@/auth/components/Logo';
import { Title } from '@/auth/components/Title';
import { FooterNote } from '@/auth/sign-in-up/components/FooterNote';
import { SignInUpForm } from '@/auth/sign-in-up/components/SignInUpForm';
import { useSignInUpForm } from '@/auth/sign-in-up/hooks/useSignInUpForm';
import { useWorkspaceFromInviteHash } from '@/auth/sign-in-up/hooks/useWorkspaceFromInviteHash';
import { currentWorkspaceState } from '@/auth/states/currentWorkspaceState';
import { Loader } from '@/ui/feedback/loader/components/Loader';
import { MainButton } from '@/ui/input/button/components/MainButton';
import { useWorkspaceSwitching } from '@/ui/navigation/navigation-drawer/hooks/useWorkspaceSwitching';

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charlesBochet charlesBochet merged commit 113e9fc into main Oct 22, 2024
11 of 12 checks passed
@charlesBochet charlesBochet deleted the TWNTY-7538 branch October 22, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants