fix: Default View Font Color and Reordering

[nganphan123]

This PR fixes issue #6114
I removed the separate check for default item and add it into the draggable list.

[greptile-apps]

PR Summary

This pull request addresses the default view font color and reordering issue in the ViewPickerListContent component.

• Removed separate handling for default view (key 'INDEX') and integrated it into the DraggableList
• Enabled reordering of the default view along with other views
• Unified font color for all views, including the default view, to primary color
• Maintained consistent icon display behavior for default and custom views
• Simplified component structure by removing conditional rendering based on view type

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile}

[Weiko]

LGTM, thank you!

[oss-gg]

Awarding nganphan123: 300 points 🕹️ Well done! Check out your new contribution on oss.gg/nganphan123

[FelixMalfait]

@Weiko I was just reviewing at the same time, I think it's missing a change so that it also reorders the sidebar

[nganphan123]

Hi @FelixMalfait , could you let me know which part of the sidebar you mentioned? I'll make any changes if needed.

[FelixMalfait]

@nganphan123 thanks a lot! Ping me and we can award 150 more points for the fix

The problem is the order here in the left sidebar which isn't affected in the same way

[nganphan123]

Got it! I'll work on that.

[nganphan123]

Hi @FelixMalfait , I couldn't reproduce the issue above. When I reorder, the left navigation bar is also updated. Is this the one you were talking about?

Screencast.from.2024-10-24.13-20-52.webm

[FelixMalfait]

@nganphan123 sorry I missed your reply. Yes that's what I was talking about. Strange I still have the issue on my side! I will check and come back to you

[FelixMalfait]

[FelixMalfait]

Oh I think I know why, there's a feature flag with 2 different ways of building the menu. You probably don't have that feature flag enabled (isWorkspaceFavoriteEnabled)

[FelixMalfait]

It's probably this: https://github.com/twentyhq/twenty/blob/main/packages/twenty-front/src/modules/object-metadata/components/NavigationDrawerItemForObjectMetadataItem.tsx#L47

I'll raise a quick fix!