Playwright basic utils #7930
Playwright basic utils #7930
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces utility functions for Playwright E2E testing, focusing on environment variables management and keyboard shortcuts handling.
packages/twenty-e2e-testing/drivers/env_variables.ts: ImplementsenvVariablesfunction, but lacks error handling and may expose sensitive datapackages/twenty-e2e-testing/lib/utils/keyboardShortcuts.ts: Adds cross-platform keyboard shortcut utilities, could benefit from more flexible shortcut definitionspackages/twenty-e2e-testing/lib/utils/pasteCodeToCodeEditor.ts: ImplementspasteCodeToCodeEditor, but may need error handling for locator failurespackages/twenty-e2e-testing/lib/utils/uploadFile.ts: AddsfileUploaderfunction, could be improved with timeout handling and file existence checks
4 file(s) reviewed, 10 comment(s)
Edit PR Review Bot Settings | Greptile
| await locator.click(); | ||
| await selectAllByKeyboard(page); | ||
| await page.keyboard.type(code); |
There was a problem hiding this comment.
style: consider adding a small delay between actions to mimic human behavior more closely
| ) => { | ||
| await locator.click(); | ||
| await selectAllByKeyboard(page); | ||
| await page.keyboard.type(code); |
There was a problem hiding this comment.
style: use page.keyboard.insertText() instead of type() for better performance with large code strings
| await trigger(); | ||
| const fileChooser = await fileChooserPromise; | ||
| await fileChooser.setFiles( | ||
| path.join(__dirname, '..', 'test_files', filename), |
There was a problem hiding this comment.
style: The hardcoded path to 'test_files' might not be flexible for all test setups. Consider making this configurable
| const fileChooserPromise = page.waitForEvent('filechooser'); | ||
| await trigger(); | ||
| const fileChooser = await fileChooserPromise; |
There was a problem hiding this comment.
logic: Ensure the trigger is called before waiting for the file chooser event to prevent potential race conditions
|
/award 500 |
|
Awarding BOHEUS: 500 points 🕹️ Well done! Check out your new contribution on oss.gg/BOHEUS |
Related to #6641