Minor page header fix #7927
Merged
Minor page header fix #7927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ehconitin
commented
Oct 21, 2024
ehconitin
commented
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request simplifies the PageHeader component by removing the width prop, potentially affecting the layout in scenarios where custom widths were previously used.
- Removed
widthprop fromPageHeadercomponent inpackages/twenty-front/src/modules/ui/layout/page/components/PageHeader.tsx - Eliminated
widthproperty fromStyledTopBarContainerstyled component - Default width now set to 100% for non-mobile viewports
- May impact layouts where custom header widths were previously specified
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
charlesBochet
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.