fix(website): enable // in token form URL input #7923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request modifies the updateBaseUrl function in the token form component to allow double slashes in custom URL inputs, addressing issue #7861.
- Updated
packages/twenty-website/src/app/_components/playground/token-form.tsxto simplify URL processing for custom inputs - Removed logic that strips trailing slashes from custom base URLs
- Enables users to type 'https://' in the URL field without issues
- Improves user experience when entering custom API endpoints in the token form
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
charlesBochet
approved these changes
Oct 21, 2024
|
Awarding unrenamed: 50 points 🕹️ Well done! Check out your new contribution on oss.gg/unrenamed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7861