fix: context menu padding #7918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses the padding issue in the context menu by modifying the ActionMenuDropdown component.
- Wrapped each MenuItem with DropdownMenuItemsContainer in
packages/twenty-front/src/modules/action-menu/components/ActionMenuDropdown.tsx - Improved visual consistency with other components like filter/sort feature
- Addressed issue Right click record menu has no padding #7915 regarding lack of padding in right-click record menu
- Enhanced user interface by adding 4px padding to menu items
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/action-menu/components/ActionMenuDropdown.tsx
Outdated
Show resolved
Hide resolved
|
Awarding Vardhaman619: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/Vardhaman619 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue #7915 regarding the lack of padding in the right-click record menu. This PR add padding to context menu and reuse the existing component used for the filter/sort feature.