fix: date-picker flips in records cell even when there is enough space #7905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses an issue with the date-picker component in record cells flipping unnecessarily when there's sufficient space below the table.
- Removed
overflow: hiddenfromStyledTbodyinpackages/twenty-front/src/modules/object-record/record-table/record-table-body/components/RecordTableBodyDroppable.tsx - Fix allows date-picker to display correctly without flipping when space is available
- Change maintains scrolling behavior for tables with varying numbers of records
- Resolves issue Date Picker flips above even when there is enough space. #7897, which was more noticeable with fewer records in the table
- Improves user experience by ensuring consistent date-picker positioning
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
/award 150 |
|
Awarding harshrajeevsingh: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/harshrajeevsingh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7897
This PR fixes the flipping of the date-picker in the record's cell even if there is enough space below the table.
I attached a screencast to show that it's working fine now.
With this, it only flips when there is less space to accommodate the date-picker comp. Also, I tested this after adding lots of records to see if the scrolling behaviour is intact or not. And I found no issues, it's working as expected.
Screencast.from.2024-10-21.13-39-42.webm