Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

side quest: Like & Re-Tweet oss.gg Launch Tweet #7877

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

Naprila
Copy link
Contributor

@Naprila Naprila commented Oct 20, 2024

Description:
Liked & Tweeted @twentycrm on X

Points:
50

Proof:
Link: https://x.com/mkprasad_821/status/1847886807314120762

Screenshot 2024-10-20 at 11 56 54 AM

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request modifies the side quest markdown file to add a new entry, but there are discrepancies between the submission and the quest requirements.

  • Invalid tweet link in the PR body (https://x.com/mkprasad_821/status/18478868073141207622) due to incorrect tweet ID
  • PR description mentions liking and tweeting, which doesn't match the side quest requirement of quote-tweeting
  • Missing @twentycrm tag in the submitted tweet, as required by the side quest
  • Inconsistency between the PR title (Like & Re-Tweet) and the actual side quest task (Quote Tweet)

1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines 50 to 51
» 20-October-2024 by Naprila
» Link to Tweet: https://x.com/mkprasad_821/status/18478868073141207622
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Tweet ID '18478868073141207622' is too long. Standard tweet IDs are 19 digits. Verify and correct the ID.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the tweed ID

@IRONalways17
Copy link

/assign

Copy link

oss-gg bot commented Oct 20, 2024

This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest

@charlesBochet
Copy link
Member

/award 50

Copy link

oss-gg bot commented Oct 20, 2024

Awarding Naprila: 50 points 🕹️ Well done! Check out your new contribution on oss.gg/Naprila

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@charlesBochet charlesBochet merged commit 35bb1a8 into twentyhq:main Oct 20, 2024
3 checks passed
Copy link

Thanks @Naprila for your contribution!
This marks your 6th PR on the repo. You're top 5% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants