Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oss.gg side-quest-gif-magic completed #7873

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

sateshcharan
Copy link
Contributor

@sateshcharan sateshcharan commented Oct 19, 2024

image

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request adds a new entry for a GIF submission in the "Gif Magic" side quest, but introduces a critical issue of duplicate content.

  • Duplicate GIF link: The new entry by Satesh Charan uses the same link as the previous entry by Harsh Bhat in oss-gg/twenty-side-quest/5-gif-magic.md
  • Potential violation: This duplication may violate the side quest rules and needs to be addressed before merging
  • Correction needed: Satesh Charan should submit a unique GIF link to complete the challenge properly

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines 38 to 39
» 20-October-2024 by Satesh Charan
» Link to gif: https://giphy.com/gifs/oss-twentycrm-mgoYSDrjIalUL7XJzm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: The GIF link is identical to the previous entry by Harsh Bhat. Please submit a unique GIF for your entry.

@FelixMalfait FelixMalfait merged commit c5138df into twentyhq:main Oct 20, 2024
3 checks passed
@FelixMalfait
Copy link
Member

/award 150

Copy link

oss-gg bot commented Oct 20, 2024

Awarding sateshcharan: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/sateshcharan

Copy link

Thanks @sateshcharan for your contribution!
This marks your 1st PR on the repo. You're top 26% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants