fix: width in PageHeader comp #7866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses an issue with the PageHeader component's width property, fixing a potential layout problem.
- Modified
packages/twenty-front/src/modules/ui/layout/page/PageHeader.tsxto set a default width of '100%' - Prevents generation of invalid CSS value 'undefinedpx' when width prop is not provided
- Resolves issue undefinedpx in PageHeader component's width property #7864, ensuring consistent layout behavior for the PageHeader component
- Simple fix that maintains component functionality while improving robustness
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
charlesBochet
approved these changes
Oct 21, 2024
|
/award 150 |
|
Awarding harshrajeevsingh: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/harshrajeevsingh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7864
This fix prevents layout issues caused by invalid CSS and ensures that the PageHeader component works correctly when no width prop is passed.