Bug Fix: Decreased border radius of badge and changed badge parent div padding to margin #7835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd padding-bottom of badge parent to margin-top and margin-bottom
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses a visual inconsistency in the timeline component's badge sizing when only one item is present.
- Modified
StyledActivityGroupBarinEventsGroup.tsxto reduce border radius from 50% to 20px - Changed
padding-topandpadding-bottomtomargin-topandmargin-bottominStyledActivityGroupContainer - Adjustments aim to create a more square-shaped badge that aligns better with adjacent text
- Changes are purely cosmetic and do not affect component functionality
- Improvements directly address the concerns raised in issue Sizing of badge isn't good when single timeline #7811
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
ehconitin
approved these changes
Oct 19, 2024
There was a problem hiding this comment.
LGTM!
Thanks for contributing @AndrewHamal! I removed the unnecessary margins.
Also, I pushed a separate, unrelated bug fix. ;)
Update: We do need margins at the top and bottom after all. I checked Figma, and it's 12px instead of 8px. :)
|
Awarding AndrewHamal: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/AndrewHamal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Decreased the border-radius of the badge and changed the padding-top and padding-bottom of the badge parent div to margin-top and margin-bottom
Fixes #7811
How should this be tested?
Create any task, notes, or files.