Fix custom index creation missing indexFieldMetadatas #7832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses a regression in custom index creation, focusing on properly saving indexFieldMetadatas in the database. Key changes include:
- Separated index metadata creation and index migration creation into distinct functions in
index-metadata.service.ts - Updated
createIndexMetadatamethod to include error handling and checks for existing indexes - Modified
relation-metadata.service.tsto use the newcreateIndexMetadatamethod - Refactored
search.service.tsto utilize the updated IndexMetadataService methods - Improved handling of index recreation after deletion when updating tsvector expressions
These changes aim to resolve issues with nested inserts and ensure proper index creation and management across the codebase.
3 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-server/src/engine/metadata-modules/index-metadata/index-metadata.service.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/metadata-modules/index-metadata/index-metadata.service.ts
Show resolved
Hide resolved
| @@ -157,7 +157,7 @@ export class SearchService { | |||
| ); | |||
|
|
|||
| // index needs to be recreated as typeorm deletes then recreates searchVector column at alter | |||
There was a problem hiding this comment.
style: Consider moving this comment to the migration creation method for better context
charlesBochet
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Regression on custom index creation where indexFieldMetadatas were not saved properly in the DB. This is because we recently changed save() to upsert() in the indexMetadataService and upsert does not handle nesting insert properly.
I'm suggesting another fix where we separate indexMetadata creation and index migration creation in 2 different functions. Since the goal was to be able to recreate the index after being deleted when we changed the tsvector expression and indexMetadata was actually not deleted, we didn't need to recreate that part (hence the upsert) and only needed to run a migration to create the actual index in the workspace schema.
I've updated the different services and now only call createIndexMigration when we update a search vector expression.
Note: this is also fixing the sync-metadata command when running on a workspace with a custom object (including the seeded workspace which has the 'rocket' custom object), failing due to the missing 'searchVector' indexFieldMetadata