Use the correct color for workflow nodes label #7829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request updates the text color of workflow nodes in the WorkflowDiagramBaseStepNode component to align with Figma design specifications.
- Modified
StyledStepNodeLabelinpackages/twenty-front/src/modules/workflow/components/WorkflowDiagramBaseStepNode.tsxto use theme's primary font color for non-placeholder variants - Fixes issue Fix text color of workflow nodes #7058 where text color was black instead of text/primary
- Improves visual consistency with the overall design system
- Demonstrates collaboration between design (Figma) and development teams
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
We were all on stream :p |
charlesBochet
approved these changes
Oct 18, 2024
|
Thanks @Devessier for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the design from the Figma about the color to use.
Big up to @Bonapara for doing great job on the Figma!
It was done on stream!
Fixes #7058