Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows to optimize CI processes #7828

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

yadavshubham01
Copy link
Contributor

This Pull Request addresses the need to optimize our Continuous Integration (CI) workflows for Playwright tests and release processes. The changes implemented aim to reduce unnecessary resource usage by conditionally executing jobs based on relevant file changes and Implement https://github.com/tj-actions/changed-files step

Changes logs

  • Updated ci-test-docker-compose.yaml , ci-chrome-extension.yaml to check for changed files before running tests.
  • Updated ci-front.yaml , ci-utils.yaml , ci-website.yaml , ci-server.yaml to check for changed files before running tests.
  • Enhanced playwright.yml to skip unnecessary tests based on file changes.

@yadavshubham01
Copy link
Contributor Author

yadavshubham01 commented Oct 18, 2024

@charlesBochet @FelixMalfait please review this PR

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request optimizes CI workflows by implementing conditional execution based on file changes, focusing on Playwright tests and release processes.

  • Added file change checks using tj-actions/changed-files@v11 in multiple CI workflow files
  • Updated ci-test-docker-compose.yaml to skip tests if no relevant changes are detected
  • Modified ci-chrome-extension.yaml, ci-front.yaml, ci-utils.yaml, ci-website.yaml, and ci-server.yaml to conditionally run jobs based on file changes
  • Enhanced playwright.yml (not shown in provided files) to skip unnecessary tests based on file changes

No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@charlesBochet
Copy link
Member

Thank you @yadavshubham01, that's it!

@charlesBochet charlesBochet merged commit b914182 into twentyhq:main Oct 21, 2024
19 checks passed
@charlesBochet
Copy link
Member

/award 300

Copy link

oss-gg bot commented Oct 21, 2024

Awarding yadavshubham01: 300 points 🕹️ Well done! Check out your new contribution on oss.gg/yadavshubham01

@charlesBochet
Copy link
Member

@yadavshubham01 could you make the CI work on merge in main?

Changed files is working great for the pull request case where we can compare file between main and the PR but does not work when we push on main (once the PR is merged, it re-triggers the CI)

image

We would need:

  • keep the CI logic as it was before for push events (conditional on paths + avoid using changed-files)
  • keep the CI logis as in your change for pr events (no conditional paths + using changed-files)

Would be great if you could take care of it!

We can award 300 additonal points :)

@charlesBochet
Copy link
Member

Actually it seems that it should be supported https://github.com/tj-actions/changed-files

@charlesBochet
Copy link
Member

ok, it's good then!

@yadavshubham01
Copy link
Contributor Author

@charlesBochet thank you for your feedback 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants