-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflows to optimize CI processes #7828
Update workflows to optimize CI processes #7828
Conversation
@charlesBochet @FelixMalfait please review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request optimizes CI workflows by implementing conditional execution based on file changes, focusing on Playwright tests and release processes.
- Added file change checks using
tj-actions/changed-files@v11
in multiple CI workflow files - Updated
ci-test-docker-compose.yaml
to skip tests if no relevant changes are detected - Modified
ci-chrome-extension.yaml
,ci-front.yaml
,ci-utils.yaml
,ci-website.yaml
, andci-server.yaml
to conditionally run jobs based on file changes - Enhanced
playwright.yml
(not shown in provided files) to skip unnecessary tests based on file changes
No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
Thank you @yadavshubham01, that's it! |
/award 300 |
Awarding yadavshubham01: 300 points 🕹️ Well done! Check out your new contribution on oss.gg/yadavshubham01 |
@yadavshubham01 could you make the CI work on merge in main? Changed files is working great for the pull request case where we can compare file between main and the PR but does not work when we push on main (once the PR is merged, it re-triggers the CI) We would need:
Would be great if you could take care of it! We can award 300 additonal points :) |
Actually it seems that it should be supported https://github.com/tj-actions/changed-files |
ok, it's good then! |
@charlesBochet thank you for your feedback 🎉 |
This Pull Request addresses the need to optimize our Continuous Integration (CI) workflows for Playwright tests and release processes. The changes implemented aim to reduce unnecessary resource usage by conditionally executing jobs based on relevant file changes and Implement https://github.com/tj-actions/changed-files step
Changes logs
ci-test-docker-compose.yaml , ci-chrome-extension.yaml
to check for changed files before running tests.ci-front.yaml , ci-utils.yaml , ci-website.yaml , ci-server.yaml
to check for changed files before running tests.playwright.yml
to skip unnecessary tests based on file changes.