[sentry fix] handle undefined createdBy case #7818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request modifies the CreatedByPreQueryHook class to handle cases where datum.createdBy is undefined, addressing a Sentry error in the production environment.
- Added optional chaining (
?.) increated-by.pre-query-hook.tsto safely accessdatum.createdBy.name - Introduced a fallback mechanism to use
createdBydata whendatum.createdByis undefined or lacks a name - Modified the condition to set
createdByfor each datum, improving robustness - Preserved the existing
sourcefromdatum.createdByif available, ensuring data integrity - Potential for further optimization by refactoring the createdBy assignment logic
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Weiko
approved these changes
Oct 18, 2024
| @@ -101,7 +101,7 @@ export class CreatedByPreQueryHook implements WorkspaceQueryHookInstance { | |||
|
|
|||
| for (const datum of payload.data) { | |||
| // Front-end can fill the source field | |||
| if (createdBy && (!datum.createdBy || !datum.createdBy.name)) { | |||
| if (createdBy && (!datum.createdBy || !datum.createdBy?.name)) { | |||
There was a problem hiding this comment.
I think there is a redundant check here, wdyt?
Could be
if (createdBy && (!datum.createdBy?.name))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sentry https://twenty-v7.sentry.io/issues/5998085857/?alert_rule_id=15135094&alert_type=issue&environment=prod¬ification_uuid=9a6c6c3d-6bd1-4c7f-bf27-8acb3571bbc3&project=4507072499810304&referrer=discord