Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update event webhook triggering #7814

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix update event webhook triggering #7814

merged 1 commit into from
Oct 18, 2024

Conversation

martmull
Copy link
Contributor

See title

@martmull martmull linked an issue Oct 18, 2024 that may be closed by this pull request
Webhooks are not triggered on update events #7813
Closed
@martmull martmull marked this pull request as ready for review October 18, 2024 08:17
greptile-apps[bot]
greptile-apps bot reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses an issue with webhook triggering for update events in the GraphQL query runner service.

  • Introduced resultWithGettersArray in graphql-query-runner.service.ts to ensure consistent array handling of query results
  • Modified executePostQueryHooks and triggerWebhooks methods to use resultWithGettersArray, fixing update event webhook issues
  • Improved type safety by explicitly handling array and non-array results
  • Ensured webhook triggering logic consistently receives an array of results across all operation types

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

ehconitin
ehconitin approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@ehconitin ehconitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martmull martmull merged commit 0c24001 into main Oct 18, 2024
5 checks passed
@martmull martmull deleted the 7813-webhooks-are-not-triggered-on-update-events branch October 18, 2024 08:20
martmull added a commit that referenced this pull request Oct 18, 2024
@martmull
Fix update event webhook triggering (#7814)
f8ff334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@ehconitin ehconitin ehconitin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webhooks are not triggered on update events
2 participants
@martmull @ehconitin