Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] install node version before corepack enable #7809

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Hitarthsheth07
Copy link
Contributor

FIX #7696

This correctly installs the recommended node version before enabling corepack.

Screenshot 2024-10-14 142628

Thanks!

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request updates the local setup instructions for Windows (WSL) users, addressing an issue with the installation order of Node.js and corepack enablement.

  • Modified packages/twenty-website/src/content/developers/local-setup.mdx to correct the installation sequence
  • Added instructions to install and use the recommended Node.js version before enabling corepack
  • Included a reminder to close and reopen the terminal after installing nvm
  • Improved clarity of the installation process for Windows (WSL) users

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines +202 to 205
To build Twenty server and seed some data into your database, run the following command:
```bash
nvm install # installs recommended node version
nvm use # use recommended node version
yarn
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: This step no longer installs Node.js as it's done earlier. Consider updating the description to reflect this change.

@Hitarthsheth07
Copy link
Contributor Author

@Devessier @lucasbordeau heyy,
Can someone please review this pr, a ton of people are facing problem due to this minor documentation error.

Cheers!

@Hitarthsheth07
Copy link
Contributor Author

@Bonapara please check this one!

@charlesBochet charlesBochet merged commit b87c7d4 into twentyhq:main Oct 21, 2024
4 checks passed
@charlesBochet
Copy link
Member

thank you @Hitarthsheth07

@charlesBochet
Copy link
Member

/award 150

Copy link

oss-gg bot commented Oct 21, 2024

Awarding Hitarthsheth07: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/Hitarthsheth07

@Hitarthsheth07 Hitarthsheth07 deleted the docs-update branch October 29, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to install node.js before running corepack enable in Windows (WSL) Local Setup
2 participants