added left padding in filter chip #7800
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request adds left padding to the SortOrFilterChip component, potentially affecting the spacing and layout of filter chips throughout the application.
- Modified
packages/twenty-front/src/modules/views/components/SortOrFilterChip.tsxto include a left margin of 8px - The hardcoded 8px value may not align with the existing theme-based spacing system
- Consider the impact on overall layout consistency, especially in different contexts where the chip is used
- Evaluate if this change should be applied universally or if it's addressing a specific use case
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -42,6 +42,7 @@ const StyledChip = styled.div<{ variant: SortOrFitlerChipVariant }>` | |||
| padding: ${({ theme }) => theme.spacing(0.5) + ' ' + theme.spacing(2)}; | |||
| user-select: none; | |||
| white-space: nowrap; | |||
| margin-left: 8px; | |||
There was a problem hiding this comment.
style: Consider using theme-based spacing for consistency
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
|
@SShanks451 thanks for the PR, is there any open issue motivating this change? If yes could you link it? Also, please use the theme instead of a hardcoded pixel value |
|
@charlesBochet updated the PR...please review |
|
Awarding SShanks451: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/SShanks451 |
Fixes: #7779