Migrate to twenty-ui - layout/animated-placeholder #7794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gitstart-app[bot]](https://avatars.githubusercontent.com/in/46283?s=60&v=4){kind=small}
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request migrates the animated-placeholder components from the twenty-front package to the twenty-ui library, updating import statements across multiple files.
- Moved
AnimatedPlaceholderand related components topackages/twenty-ui/src/layout/animated-placeholder/ - Updated import statements in various files to use
twenty-uiinstead of local imports - Created new index files in
twenty-uito export the migrated components and constants - Maintained existing functionality of components while improving import structure
- Ensured consistent naming conventions for exported styled components (e.g., prefixing with 'AnimatedPlaceholder')
20 file(s) reviewed, 19 comment(s)
Edit PR Review Bot Settings | Greptile
| AnimatedPlaceholderEmptyContainer, | ||
| AnimatedPlaceholderEmptyTextContainer, | ||
| AnimatedPlaceholderEmptyTitle, | ||
| } from '@/ui/layout/animated-placeholder/components/EmptyPlaceholderStyled'; | ||
| } from 'twenty-ui'; | ||
|
|
||
| export const EmailLoader = ({ loadingText }: { loadingText?: string }) => ( |
There was a problem hiding this comment.
style: Consider adding a type definition for the loadingText prop
|
@gitstart-twenty could you rebase this one? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by GitStart to address the requirements from this ticket: TWNTY-7531.
Description
animated-placeholdertotwenty-uiand update all imports.Fixes twentyhq/private-issues#87