Migrate to twenty-ui - navigation/breadcrumb #7793
Conversation
![gitstart-app[bot]](https://avatars.githubusercontent.com/in/46283?s=60&v=4){kind=small}
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR migrates the Breadcrumb component from the twenty-front package to the twenty-ui library, centralizing UI components for improved maintainability.
- Moved Breadcrumb component to
packages/twenty-ui/src/navigation/breadcrumb/components/Breadcrumb.tsx - Updated import statements in multiple files to use Breadcrumb from 'twenty-ui'
- Removed
packages/twenty-front/src/modules/ui/navigation/bread-crumb/components/__stories__/Breadcrumb.stories.tsx - Added export for navigation components in
packages/twenty-ui/src/index.ts - Updated
packages/twenty-front/tsup.ui.index.tsxto export all components from 'twenty-ui'
8 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| `; | ||
|
|
||
| const StyledDivider = styled.span` | ||
| width: ${({ theme }) => theme.spacing(2)}; |
There was a problem hiding this comment.
style: The divider width is fixed. Consider making it customizable through props
| ) : ( | ||
| <StyledText title={text}>{link.children}</StyledText> | ||
| )} | ||
| {index < links.length - 1 && <StyledDivider>/</StyledDivider>} |
There was a problem hiding this comment.
style: Consider making the divider customizable through props
There was a problem hiding this comment.
Thanks for the PR @gitstart-twenty
Feedbacks:
- I'm surprised we are not removing the Breadcrumb.tsx component
- And why is the story not migrated?
Thanks for thanks for the feedback.
Apologies, we would remove the
This is due to the tight coupling that currently exists in the storybook's decorator ( We started a discussion here on discord to clarify the convention to adopt in such cases, and Lucas clarified that, we can do the same for now, and let the stories in twenty-front. |
Description
twenty-uiFixes #7534