Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(front): move "Add to favorites" btn to start of action menu #7785

Merged

Conversation

unrenamed
Copy link
Contributor

What does this PR do?

Moves the "Add to favourites" action button to the beginning of the action menu, thus moving the "Delete" button to its right edge.

Fixes #7780.

image

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request modifies the action menu order in the SingleRecordActionMenuEntriesSetter component, addressing issue #7780 by repositioning the 'Add to favorites' and 'Delete' buttons.

  • Moved ManageFavoritesActionEffect to the start of the actionEffects array in SingleRecordActionMenuEntriesSetter.tsx
  • Placed DeleteRecordsActionEffect at the end of the actionEffects array
  • This change ensures 'Add to favorites' appears first and 'Delete' last in the action menu
  • Improves user experience by making frequently used actions more accessible
  • Aligns with the desired behavior outlined in the related issue

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@unrenamed unrenamed changed the title fix(front): move "Add to favorites" btn to start of action menu (#7780) fix(front): move "Add to favorites" btn to start of action menu Oct 17, 2024
@ehconitin ehconitin self-assigned this Oct 17, 2024
Copy link
Contributor

@ehconitin ehconitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thankyou!

@ehconitin ehconitin merged commit c07650f into twentyhq:main Oct 17, 2024
9 of 11 checks passed
Copy link

oss-gg bot commented Oct 17, 2024

Awarding unrenamed: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/unrenamed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Delete to the right edge of action menu
2 participants