Add modal to confirm workflow draft version overriding #7758
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces a confirmation modal for overriding existing workflow draft versions, enhancing user experience and preventing accidental data loss.
- Added
AdditionalButtonsprop toConfirmationModalinpackages/twenty-front/src/modules/ui/layout/modal/components/ConfirmationModal.tsxfor flexible button configurations - Created new
OverrideWorkflowDraftConfirmationModalcomponent inpackages/twenty-front/src/modules/workflow/components/OverrideWorkflowDraftConfirmationModal.tsxto handle draft override confirmations - Implemented Recoil state management for modal visibility in
packages/twenty-front/src/modules/workflow/states/openOverrideWorkflowDraftConfirmationModalState.ts - Updated
RecordShowPageWorkflowVersionHeaderinpackages/twenty-front/src/modules/workflow/components/RecordShowPageWorkflowVersionHeader.tsxto integrate the new confirmation modal
4 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -138,6 +141,9 @@ export const ConfirmationModal = ({ | |||
| title="Cancel" | |||
| fullWidth | |||
| /> | |||
|
|
|||
| {AdditionalButtons} | |||
There was a problem hiding this comment.
style: Consider wrapping AdditionalButtons in a conditional to avoid rendering empty space when not provided
There was a problem hiding this comment.
I don't think it can cause problems. If AdditionalButtons equals undefined, React will render nothing.
| isOpen={openOverrideWorkflowDraftConfirmationModal} | ||
| setIsOpen={setOpenOverrideWorkflowDraftConfirmationModal} | ||
| title="A draft already exists" | ||
| subtitle="A draft already exists for this workflow. Are you sure to erase it?" |
There was a problem hiding this comment.
style: The subtitle grammar could be improved
There was a problem hiding this comment.
indeed
| subtitle="A draft already exists for this workflow. Are you sure to erase it?" | |
| subtitle="A draft already exists for this workflow. Are you sure you want to erase it?" |
...ages/twenty-front/src/modules/workflow/components/OverrideWorkflowDraftConfirmationModal.tsx
Show resolved
Hide resolved
| @@ -46,6 +48,7 @@ export const RecordShowPageWorkflowVersionHeader = ({ | |||
| skip: !isDefined(workflowVersion), | |||
| limit: 1, | |||
| }); | |||
| const draftWorkflowVersion = draftWorkflowVersions[0]; | |||
There was a problem hiding this comment.
style: Ensure draftWorkflowVersion is properly typed as WorkflowVersion | undefined
| await updateOneWorkflowVersion({ | ||
| idToUpdate: draftWorkflowVersionId, | ||
| updateOneRecordInput: workflowVersionUpdateInput, | ||
| }); |
There was a problem hiding this comment.
could you check with @Bonapara if we expect a redirection afterwards?
… the draft workflow version
Devessier
force-pushed
the
confirm-workflow-draft-override-modal
branch
from
67f6c9b
to
813526e
Compare
|
Thanks @Devessier for your contribution! |
In this PR:
<ConfirmationModal />to take additional buttons to display between the cancel and the confirm buttons.A demo:
CleanShot.2024-10-16.at.17.01.13.mp4
Closes twentyhq/private-issues#114