update makefile rules to use docker run #7747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request simplifies the Makefile and local setup instructions by replacing complex Docker run commands with streamlined Makefile commands for PostgreSQL and Redis setup.
- Updated
Makefileto use direct Docker run commands for PostgreSQL and Redis, removing environment-specific options - Modified
packages/twenty-website/src/content/developers/local-setup.mdxto use new Makefile commands (make postgres-on-dockerandmake redis-on-docker) - Simplified setup process across different operating systems by abstracting Docker configurations into the Makefile
- Removed previously available Docker-related commands, which may impact some contributors' development workflows
- Improved maintainability of the setup process by centralizing Docker configurations in the Makefile
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7739
FYI @BOHEUS, thanks