Fix tests #7722
Merged
Fix tests #7722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request modifies the useSearchRecords hook and updates GraphQL mocks for testing, focusing on search functionality improvements and debugging.
- Added
console.log(effectiveData)inuseSearchRecords.ts, which may expose sensitive data and impact performance - Replaced 'FindManyViews' with 'SearchPeople', 'SearchCompanies', and 'SearchOpportunities' queries in
graphqlMocks.ts - 'SearchOpportunities' query returns an empty array, potentially requiring mock data for comprehensive testing
- Ensure the new console.log statement is removed or properly managed before production deployment
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -83,6 +83,8 @@ export const useSearchRecords = <T extends ObjectRecord = ObjectRecord>({ | |||
| [result], | |||
| ); | |||
|
|
|||
| console.log(effectiveData); | |||
There was a problem hiding this comment.
style: Remove or conditionally log only in development environment
FelixMalfait
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title ;)