Remove pgGraphql from setup #7716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request removes pg_graphql from the PostgreSQL setup, simplifying the database configuration and local development process.
- Removed pg_graphql extension files and related setup scripts from various architectures (Linux AMD64/ARM64, macOS ARM)
- Deleted Dockerfiles and docker-compose.yml files specific to pg_graphql setup
- Removed initialization SQL scripts and Makefiles for platform-specific PostgreSQL provisioning
- Updated Dockerfiles for twenty-postgres and twenty-postgres-spilo to exclude pg_graphql-related configurations
- Eliminated build and provision scripts for PostgreSQL with pg_graphql on Linux systems
30 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -38,10 +37,9 @@ WORKDIR /build/openssl | |||
| RUN ./config && make && make install | |||
|
|
|||
|
|
|||
| # Extend the Spilo image with the pg_graphql and mysql_fdw extensions | |||
| # Extend the Spilo image with the mysql_fdw extensions | |||
There was a problem hiding this comment.
style: Update comment to reflect that only mysql_fdw extension is being added
There was a problem hiding this comment.
logic: Removing database creation may affect application functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR removes pg_graphql from the setup. It also updates the local setup documentation accordingly.
Note: We removed local setup scripts to align with redis installation, the setup should be much simpler since we don't rely on pg_graphql anymore.
Test
tested locally with docker + mac (brew) setup