Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Jobs to tsx footer #7706

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Added Jobs to tsx footer #7706

merged 2 commits into from
Oct 16, 2024

Conversation

Bonapara
Copy link
Member

CleanShot 2024-10-15 at 09 32 23

New "Jobs"

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request updates the FooterDesktop component in the Twenty website, adding new links and renaming an existing one to enhance user navigation and resource accessibility.

  • Added 'User-Guide' and 'Jobs' links to the footer in /packages/twenty-website/src/app/_components/ui/layout/FooterDesktop.tsx
  • Renamed 'Changelog' to 'Releases' for better clarity
  • Minor inconsistency in naming convention: 'User-Guide' should be 'User Guide' to match other link styles
  • New links are correctly implemented and styled consistently with existing footer links
  • Changes improve footer content by providing additional resources for users

1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines 95 to 97
<RightSideFooterLink href="/user-guide">
User-Guide
</RightSideFooterLink>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: 'User-Guide' should be 'User Guide' for consistency with other link text

@charlesBochet
Copy link
Member

@Bonapara LGTM but could you fix the CI? (linter)

@charlesBochet charlesBochet merged commit a88c2fa into main Oct 16, 2024
6 checks passed
@charlesBochet charlesBochet deleted the Footer-update branch October 16, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants