Fix DateTimeSettingsTimeZoneSelect #7688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijreilly
commented
Oct 14, 2024
| @@ -25,7 +26,9 @@ export const DateTimeSettingsTimeZoneSelect = ({ | |||
| value={value} | |||
| options={[ | |||
| { | |||
| label: `System settings - ${systemTimeZoneOption.label}`, | |||
| label: isDefined(systemTimeZoneOption) | |||
There was a problem hiding this comment.
@lucasbordeau do you have knowledge on this ? I don't know when systemTimeZoneOption can be undefined
There was a problem hiding this comment.
The typing of findAvailableTimeZoneOption should certainly be SelectOption<string> | undefined since it indexes a dictionary and the key could be nonexistent.
There was a problem hiding this comment.
We should open an issue, as :
- The typing should be fixed
- We should investigate why it is trying to index a non existent key
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses a Sentry error in the DateTimeSettingsTimeZoneSelect component by adding a safety check for undefined values.
- Added
isDefinedimport and usage inpackages/twenty-front/src/pages/settings/profile/appearance/components/DateTimeSettingsTimeZoneSelect.tsxto prevent "Cannot read properties of undefined (reading 'label')" error - Implemented conditional rendering for the system time zone label, improving component robustness
- The fix maintains the component's core functionality while enhancing its error handling capabilities
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
lucasbordeau
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing sentry Cannot read properties of undefined (reading 'label')