-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] : Horizontal scroll issue in dropdown #7682
Conversation
here I changed the hard-coded width value to a dynamic value which will be calculated based on the parent container.
Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request addresses a horizontal scroll issue in the dropdown menu by modifying the width calculation of the StyledMenuItem component.
- Changed width in
RecordIndexPageKanbanAddMenuItem.tsx
from fixed 200px tocalc(100% - 2 * var(--horizontal-padding))
- Improved responsiveness of the dropdown menu to adapt to different screen sizes
- Potential dependency on proper definition of
--horizontal-padding
CSS variable across contexts
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Please take a look at the pull request and code changes. Let me know if any additional changes are required. |
...front/src/modules/object-record/record-index/components/RecordIndexPageKanbanAddMenuItem.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
...front/src/modules/object-record/record-index/components/RecordIndexPageKanbanAddMenuItem.tsx
Show resolved
Hide resolved
Awarding AmanPathan: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/AmanPathan |
In this PR, I changed the hard-coded width value to a dynamic value which will be calculated based on the parent container.
This PR closes issue: #7615