cleanup pg_graphql #1 #7673
cleanup pg_graphql #1 #7673
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request focuses on removing components related to pg_graphql as part of a larger effort to deprecate it and streamline the codebase. The changes primarily affect the workspace-query-builder and workspace-query-runner modules.
- Removed multiple factory classes in
packages/twenty-server/src/engine/api/graphql/workspace-query-builder/factories/, including those for creating, updating, and deleting queries - Deleted
WorkspaceQueryRunnerServiceand its associated module, impacting database operations previously handled by pg_graphql - Removed
AISQLQueryModuleand related files, affecting AI-assisted SQL query generation functionality - Updated
TRACKmutation parameters in analytics module, simplifying from 'type', 'sessionId', and 'data' to 'action' and 'payload' - Simplified
workspaceQueryBuilderFactoriesarray, retaining onlyRecordPositionQueryFactoryandForeignDataWrapperServerQueryFactory
30 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
logic: Removing CreateManyQueryFactory may break bulk record creation functionality. Ensure alternative implementation is in place.
| @@ -1,34 +1,8 @@ | |||
| import { ForeignDataWrapperServerQueryFactory } from 'src/engine/api/graphql/workspace-query-builder/factories/foreign-data-wrapper-server-query.factory'; | |||
There was a problem hiding this comment.
style: Consider updating import path to use relative import for consistency with line 3
There was a problem hiding this comment.
logic: Removing FieldsStringFactory may break GraphQL query generation. Ensure all dependencies are updated.
| providers: [ | ||
| WorkspaceQueryRunnerService, | ||
| ...workspaceQueryRunnerFactories, | ||
| EntityEventsToDbListener, | ||
| TelemetryListener, | ||
| RecordPositionBackfillCommand, | ||
| ], |
There was a problem hiding this comment.
logic: Removal of WorkspaceQueryRunnerService may impact module functionality. Ensure all dependencies are handled.
There was a problem hiding this comment.
logic: Removing this entire file is a major change. Ensure all dependencies and references to WorkspaceQueryRunnerService are removed or replaced throughout the codebase.
Context
This PR removes workspace-query-runner/builder in preparation for fully deprecating pg_graphql
next steps: Remove from the setup and make a command to remove comments on schema/tables related to pg_graphql