Allow use of paru in addition to yay as aur helper
#7652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request modifies the PostgreSQL installation script to include support for the 'paru' AUR helper alongside 'yay' on Arch Linux systems.
- Added 'paru' as an alternative AUR helper in
/packages/twenty-postgres/linux/provision-postgres-linux.sh - Improves compatibility for Arch Linux users who prefer 'paru' over 'yay'
- Maintains backward compatibility with existing 'yay' installation method
- Enhances the script's flexibility in handling different Arch Linux setups
- Consider adding error handling for cases where neither 'yay' nor 'paru' is available
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -98,7 +98,7 @@ elif [ "$PACKAGE_MANAGER" = "pacman" ]; then | |||
| sudo pacman -S postgresql postgresql-libs curl --noconfirm || handle_error "Failed to install PostgreSQL or curl." | |||
|
|
|||
| echo_header $GREEN "Step [2/4]: Installing GraphQL for PostgreSQL on Arch..." | |||
| if ! yay -S --noconfirm pg_graphql; then | |||
| if ! yay -S --noconfirm pg_graphql && ! paru -S --noconfirm pg_graphql; then | |||
There was a problem hiding this comment.
logic: The '!' operator might cause the script to exit if the first command fails, potentially preventing 'paru' from being tried
charlesBochet
approved these changes
Oct 13, 2024
|
/award 150 |
|
Awarding eldyl: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/eldyl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Twenty Team,
If this is not an appropriate PR, please feel to close it. I am hoping to make larger contributions down the road.
I was getting twenty setup locally, and I had a problem with the install script. I noticed that
yaywas named as an AUR helper, butparuwas not. I use paru, and this caused the setup script to fail.I made a small change in the if statement that checks if
pg-graphqlcan be installed withyay. I included a check forparuon the same line.Thanks everyone who has made this project what it is.