Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor - ts error fix #7635

Merged
merged 3 commits into from
Oct 13, 2024
Merged

minor - ts error fix #7635

merged 3 commits into from
Oct 13, 2024

Conversation

ehconitin
Copy link
Contributor

@FelixMalfait :) follow up - #7628

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request introduces minor changes to improve navigation behavior in the settings drawer of the Twenty front-end application.

  • Added matchSubPages property to 'Emails' and 'Calendars' items in SettingsNavigationDrawerItems.tsx
  • Adjusted logic for determining active paths in navigation drawer items
  • Improved selection behavior for API & Webhook and Functions items, addressing issue Fix: Nav Item Api & Webhook and Functions stay selected #7628
  • Enhanced user experience by ensuring selected items maintain their active state

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@FelixMalfait FelixMalfait merged commit 5ca4750 into twentyhq:main Oct 13, 2024
11 checks passed
Copy link

Thanks @ehconitin for your contribution!
This marks your 47th PR on the repo. You're top 1% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants