Fix lessThan operator not applying column case #7624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request refactors the GraphqlQueryFilterFieldParser class and fixes the 'lt' operator for proper column case handling in SQL queries.
- Extracted
computeWhereConditionPartsfunction into a new utility filepackages/twenty-server/src/engine/api/graphql/graphql-query-runner/utils/compute-where-condition-parts.ts - Fixed 'lt' (less than) operator in
computeWhereConditionPartsto ensure correct column case handling - Improved code organization and reusability by separating the SQL condition generation logic
- Implemented parameterized queries in
computeWhereConditionPartsto prevent SQL injection - Added support for various operators including comparison, 'in', 'is' (NULL checks), and string matching (like, ilike, startsWith, endsWith)
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+72
to
+76
| case 'startsWith': | ||
| return { | ||
| sql: `"${objectNameSingular}"."${key}" LIKE :${key}${uuid}`, | ||
| params: { [`${key}${uuid}`]: `${value}` }, | ||
| }; |
There was a problem hiding this comment.
logic: startsWith and endsWith cases should append % to the value
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ty-server/src/engine/api/graphql/graphql-query-runner/utils/compute-where-condition-parts.ts
Dismissed
Show dismissed
Hide dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our postgres column naming convention is camelCase ; this forces SQL queries to wrap column names with double quotes.
We previously forgot the quotes in a filter parsing case