-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: content getting hide on drag and drop in stage view cards #7621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request addresses the issue of content hiding during drag and drop operations in stage view cards by implementing the InView
component in the RecordBoardCard
component.
- Introduced
InView
component inRecordBoardCard.tsx
to maintain content visibility during drag and drop - Removed
StyledRecordInlineCellPlaceholder
andinView
variable, simplifying the component structure - Improved user experience by ensuring card content remains visible during drag operations in both Kanban and Table views
- Aligned implementation with desired behavior described in issue Display Record content when drag & dropping #7388
- Modified
RecordBoardCard
component to directly render content without conditional visibility checks
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Nabhag8848, I've played with it and it feels nice except for the drag and drop on the RecordTable: column size do not look to be respected
Could you fix it?
@Nabhag8848 up on this one :) |
Thanks, was aware, swamped with work. I'll handle it soon! |
will need to fix #7290 first. in my current solution column size is still breaking when column size is changed as checkbox with is changing + some need to fix some weird behaviours |
@charlesBochet should we merge just kanban changes which are working as expected ? I can revert table record changes from this PR and for table records, we can make a seperate PR while we fix dependant issues ? |
/award 300 |
Awarding Nabhag8848: 300 points 🕹️ Well done! Check out your new contribution on oss.gg/Nabhag8848 |
Thanks @Nabhag8848 for your contribution! |
ISSUE
Demo
Screen.Recording.2024-10-12.at.8.16.24.PM.mov