Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: content getting hide on drag and drop in stage view cards #7621

Merged
merged 16 commits into from
Nov 5, 2024

Conversation

Nabhag8848
Copy link
Contributor

@Nabhag8848 Nabhag8848 commented Oct 12, 2024

ISSUE

Demo

Screen.Recording.2024-10-12.at.8.16.24.PM.mov
  • Table Row Drag WIP

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses the issue of content hiding during drag and drop operations in stage view cards by implementing the InView component in the RecordBoardCard component.

  • Introduced InView component in RecordBoardCard.tsx to maintain content visibility during drag and drop
  • Removed StyledRecordInlineCellPlaceholder and inView variable, simplifying the component structure
  • Improved user experience by ensuring card content remains visible during drag operations in both Kanban and Table views
  • Aligned implementation with desired behavior described in issue Display Record content when drag & dropping #7388
  • Modified RecordBoardCard component to directly render content without conditional visibility checks

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Nabhag8848, I've played with it and it feels nice except for the drag and drop on the RecordTable: column size do not look to be respected

Could you fix it?

@charlesBochet
Copy link
Member

@Nabhag8848 up on this one :)

@Nabhag8848
Copy link
Contributor Author

Thanks, was aware, swamped with work. I'll handle it soon!

@Nabhag8848
Copy link
Contributor Author

Nabhag8848 commented Oct 20, 2024

will need to fix #7290 first.

in my current solution column size is still breaking when column size is changed as checkbox with is changing + some need to fix some weird behaviours

@Nabhag8848
Copy link
Contributor Author

@charlesBochet should we merge just kanban changes which are working as expected ? I can revert table record changes from this PR and for table records, we can make a seperate PR while we fix dependant issues ?

@charlesBochet
Copy link
Member

/award 300

Copy link

oss-gg bot commented Oct 31, 2024

Awarding Nabhag8848: 300 points 🕹️ Well done! Check out your new contribution on oss.gg/Nabhag8848

@lucasbordeau lucasbordeau merged commit 3793f6c into twentyhq:main Nov 5, 2024
17 checks passed
Copy link

github-actions bot commented Nov 5, 2024

Thanks @Nabhag8848 for your contribution!
This marks your 20th PR on the repo. You're top 2% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Record content when drag & dropping
3 participants