Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: API ObjectMetadata labelSingular and labelPlural which eventually solves typo in dropdown #7614

Merged
merged 4 commits into from
Oct 13, 2024

Conversation

Nabhag8848
Copy link
Contributor

ISSUE

Description

  • Fixes typo in dropdown + in general any apikeys label around.

@Nabhag8848
Copy link
Contributor Author

Nabhag8848 commented Oct 12, 2024

@CoreTeamTwenty ready for review

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request corrects a typo in the API key labels within the api-key.workspace-entity.ts file, changing 'Api Key' to 'API Key' for improved consistency and accuracy in the application's UI.

  • Modified packages/twenty-server/src/modules/api-key/standard-objects/api-key.workspace-entity.ts to update labelSingular and labelPlural from 'Api Key' to 'API Key'
  • Fixes issue Typo in Settings > Advanced > API & Webhooks > webhook details #7478 where 'Api key' was incorrectly displayed in dropdown menus
  • Ensures consistent capitalization of 'API' throughout the application
  • Improves user experience in the Settings > Advanced > API & Webhooks section

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@charlesBochet
Copy link
Member

@Nabhag8848 LGTM but you have conflicts, could you solve them?

@Nabhag8848
Copy link
Contributor Author

@charlesBochet 🙌🏼

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charlesBochet
Copy link
Member

/award 150

Copy link

oss-gg bot commented Oct 13, 2024

Awarding Nabhag8848: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/Nabhag8848

@charlesBochet charlesBochet merged commit 508252b into twentyhq:main Oct 13, 2024
14 checks passed
Copy link

Thanks @Nabhag8848 for your contribution!
This marks your 18th PR on the repo. You're top 2% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

@ketanMehtaa
Copy link
Contributor

@Nabhag8848 are these changes working in frontend ?

@Nabhag8848
Copy link
Contributor Author

Nabhag8848 commented Oct 14, 2024

@ketanMehtaa yes, we are storing objectMetadata information in database, you need to run database:reset command to have updated records.

you can see this under metadata database, objectMetadata table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in Settings > Advanced > API & Webhooks > webhook details
3 participants