Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use <label> HTML element when possible #7609

Merged
merged 4 commits into from
Oct 13, 2024
Merged

Use <label> HTML element when possible #7609

merged 4 commits into from
Oct 13, 2024

Commits on Oct 11, 2024

  1. fix: use a true label element for the input label

    @Devessier
    Devessier committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0b0225d View commit details
    Browse the repository at this point in the history

  2. fix: use useId hook instead of a uuid v4 for the id of an input element 

    UUID are cryptographically secure unique identifiers and take time to get generated.
It's better to use the useId hook which is made for that purpose, always returns the same value for the same hook instance, and works well with server-side rendering.
    @Devessier
    Devessier committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    eeb0155 View commit details
    Browse the repository at this point in the history

  3. refactor: provide a function setter to the setIsOn function to stop d… 

    …isabling an eslint rule
    @Devessier
    Devessier committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7e42c73 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Merge branch 'main' into use-label-html-element

    @charlesBochet
    charlesBochet committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    67fbb38 View commit details
    Browse the repository at this point in the history