Fixed bugs in ViewBar filtering #7608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucasbordeau
commented
Oct 11, 2024
lucasbordeau
commented
- Fixed CSS for SortOrFilter chips
- Fixed bug when refreshing with an actor source filter set
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses bugs in the ViewBar filtering functionality, focusing on CSS improvements for SortOrFilter chips and fixing issues with actor source filters.
- Modified 'ACTOR' case handling in
turnObjectDropdownFilterIntoQueryFilter.tsto improve filter processing for 'Is' and 'IsNot' operands - Adjusted CSS in
SortOrFilterChip.tsx, reducing padding and adding max-height for better visual consistency - Removed bottom padding from StyledChipContainer in
ViewBarDetails.tsxto improve chip alignment - These changes aim to enhance the user experience and resolve issues with actor source filters during page refreshes
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| break; | ||
| } | ||
| case ViewFilterOperand.IsNot: { | ||
| const parsedRecordIds = JSON.parse(rawUIFilter.value) as string[]; |
There was a problem hiding this comment.
style: Duplicate JSON parsing. Consider extracting this to a variable to avoid repetition
charlesBochet
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.