Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon button disabled border #7607

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

bosiraphael
Copy link
Contributor

Capture d’écran 2024-10-11 à 17 34 22

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses the border color issue for disabled icon buttons in the IconButton component.

  • Modified packages/twenty-front/src/modules/ui/input/button/components/IconButton.tsx to simplify border color logic
  • Removed conditional check for disabled state in 'default' case of 'primary' variant styling
  • Ensures consistent border color for icon buttons regardless of disabled state
  • Fixes the issue of disabled buttons having a transparent border

1 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile

@charlesBochet charlesBochet merged commit 7e7784f into main Oct 11, 2024
13 checks passed
@charlesBochet charlesBochet deleted the fix-icon-button-disabled-border branch October 11, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants