Fix optimistic effect deletedAt #7606
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Minor formatting improvement in the OpenAPI parameters utility file, specifically in the computeFilterParameters function's filter description.
- Removed a newline character in
packages/twenty-server/src/engine/core-modules/open-api/utils/parameters.utils.ts, making the filter parameter description more compact - This change does not affect the functionality of the
computeFilterParametersfunction or its interaction with optimistic effect handling
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
| deletedAt: () => recordToDelete.deletedAt, | ||
| }, | ||
| }); | ||
| cache.evict({ id: cache.identify(recordToDestroy) }); |
There was a problem hiding this comment.
reverting a previous tentative introduced here: https://github.com/twentyhq/twenty/pull/7200/files
| filter: rootQueryFilter, | ||
| objectMetadataItem, | ||
| }); | ||
| const updatedRecordMatchesThisRootQueryFilter = isRecordMatchingFilter({ |
There was a problem hiding this comment.
we should always try to matchFilter (as isDeletedAt is implicit)
| } | ||
| } | ||
|
|
||
| if (updatedRecordShouldBeRemovedFromRootQueryEdges) { |
There was a problem hiding this comment.
no changes here, just indent changes
| @@ -67,44 +68,69 @@ export const useDeleteManyRecords = ({ | |||
| (batchIndex + 1) * mutationPageSize, | |||
| ); | |||
|
|
|||
| const currentTimestamp = new Date().toISOString(); | |||
There was a problem hiding this comment.
making the useDeleteMany having the EXACT same logic as useUpdateOne but batched
| @@ -41,66 +42,85 @@ export const useDeleteOneRecord = ({ | |||
| async (idToDelete: string) => { | |||
| const currentTimestamp = new Date().toISOString(); | |||
|
|
|||
| const cachedRecord = getRecordFromCache(idToDelete, apolloClient.cache); | |||
| const findManyQueryName = `FindMany${capitalize( | ||
| objectMetadataItem.namePlural, | ||
| )}`; | ||
| const cachedRecords = idsToRestore.map((idToRestore) => |
| @@ -120,6 +127,12 @@ export const isRecordMatchingFilter = ({ | |||
| ); | |||
| } | |||
|
|
|||
| if (isLeafFilter(filter)) { | |||
There was a problem hiding this comment.
taking deletedAt into account in the isRecordMatchingFilter
| @@ -82,62 +82,62 @@ export class GraphqlQueryFilterFieldParser { | |||
| switch (operator) { | |||
| case 'eq': | |||
| return { | |||
| sql: `${objectNameSingular}.${key} = :${key}${uuid}`, | |||
| sql: `"${objectNameSingular}"."${key}" = :${key}${uuid}`, | |||
There was a problem hiding this comment.
another bug we spot with @Weiko
| @@ -84,8 +84,7 @@ export const computeFilterParameters = (): OpenAPIV3_1.ParameterObject => { | |||
| ).join('**, **')}**. | |||
| Default root conjunction is **${DEFAULT_CONJUNCTION}**. | |||
| To filter **null** values use **field[is]:NULL** or **field[is]:NOT_NULL** | |||
| To filter using **boolean** values use **field[eq]:true** or **field[eq]:false** | |||
| `, | |||
| To filter using **boolean** values use **field[eq]:true** or **field[eq]:false**`, | |||
In this PR, I'm fixing part of the impact of soft deletion on optimistic rendering.
Backend Vision
Backend current state
Right now, we have the following behavior:
Optimistic rendering strategy