fix enum default value update when option deleted #7604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request modifies the updateOne method in the FieldMetadataService class to allow setting null as a valid defaultValue when updating field metadata, particularly affecting enum fields.
- Modified
packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.service.tsto allownullvalues fordefaultValue - Changed condition in
updateOnemethod fromisDefined(defaultValue)todefaultValue !== undefined - Improves flexibility for users to reset default values to
nullwhen updating field metadata - Addresses issue where
isDefinedwas incorrectly handlingnullvalues, preventing valid updates - Ensures consistency with the intended behavior of allowing
nullas a valid default value option
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+397
to
+400
| defaultValue: | ||
| updatableFieldInput.defaultValue !== undefined | ||
| ? updatableFieldInput.defaultValue | ||
| : existingFieldMetadata.defaultValue, |
There was a problem hiding this comment.
logic: This change allows null values to be set as defaultValue. Ensure this doesn't break existing functionality for non-nullable fields.
ijreilly
approved these changes
Oct 11, 2024
Weiko
deleted the
c--fix-enum-default-value-update-when-option-deleted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix as isDefined also returns false if value is null and we still want to allow users to set defaultValue back to null