Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view bar details missing ObjectFilterDropdownComponentInstanceContext #7598

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

lucasbordeau
Copy link
Contributor

Fix view bar details missing ObjectFilterDropdownComponentInstanceContext

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses an issue with the view bar details by introducing a new context provider in the ObjectFilterDropdownScope component.

  • Added ObjectFilterDropdownComponentInstanceContext provider in packages/twenty-front/src/modules/object-record/object-filter-dropdown/scopes/ObjectFilterDropdownScope.tsx
  • Nested existing ObjectFilterDropdownScopeInternalContext within the new provider
  • Both contexts now use filterScopeId prop with different key names (instanceId and scopeId)
  • This change aims to resolve missing context in view bar details, potentially affecting filter functionality

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@charlesBochet charlesBochet merged commit f15c5ff into main Oct 11, 2024
13 checks passed
@charlesBochet charlesBochet deleted the fix/filter-from-table-column-header branch October 11, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants