improve matching filter error message #7578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the error handling in the isRecordMatchingFilter function by providing more detailed error messages for unsupported field types.
- Improved error message in
packages/twenty-front/src/modules/object-record/record-filter/utils/isRecordMatchingFilter.tsnow includes the specific field type causing the error - This change aids in debugging issues related to unsupported field types, particularly beneficial for workspaces with legacy types
- Enhanced developer experience by offering more precise information when encountering errors in record filtering
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
charlesBochet
approved these changes
Oct 10, 2024
charlesBochet
deleted the
c--improve-matching-filter-type-error-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This can be thrown when a type is not properly supported by isRecordMatchingFilter. This should not happen but for some workspaces with legacy types this should help debugging.