-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added callback url structure for self hosting #7570
Added callback url structure for self hosting #7570
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request updates the self-hosting documentation for Twenty by adding specific callback URL structures for Google and Microsoft authentication.
- Added example callback URL structure for
AUTH_GOOGLE_APIS_CALLBACK_URL
in/packages/twenty-website/src/content/developers/self-hosting/self-hosting-var.mdx
- Added example callback URL structure for
AUTH_MICROSOFT_CALLBACK_URL
in the same file - Improved clarity for self-hosting setup by providing more specific examples for authentication configuration
- Potential issue: The added URL structures may need to be reviewed for accuracy and consistency with the actual implementation
1 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
@@ -81,7 +81,7 @@ yarn command:prod cron:calendar:calendar-event-list-fetch | |||
['AUTH_MICROSOFT_CLIENT_ID', '', 'Microsoft client ID'], | |||
['AUTH_MICROSOFT_TENANT_ID', '', 'Microsoft tenant ID'], | |||
['AUTH_MICROSOFT_CLIENT_SECRET', '', 'Microsoft client secret'], | |||
['AUTH_MICROSOFT_CALLBACK_URL', '', 'Microsoft auth callback'], | |||
['AUTH_MICROSOFT_CALLBACK_URL', 'http://[YourDomain]/auth/google/redirect', 'Microsoft auth callback'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: The Microsoft auth callback URL is using the Google redirect path. This should be updated to use a Microsoft-specific path.
@@ -81,7 +81,7 @@ yarn command:prod cron:calendar:calendar-event-list-fetch | |||
['AUTH_MICROSOFT_CLIENT_ID', '', 'Microsoft client ID'], | |||
['AUTH_MICROSOFT_TENANT_ID', '', 'Microsoft tenant ID'], | |||
['AUTH_MICROSOFT_CLIENT_SECRET', '', 'Microsoft client secret'], | |||
['AUTH_MICROSOFT_CALLBACK_URL', '', 'Microsoft auth callback'], | |||
['AUTH_MICROSOFT_CALLBACK_URL', 'http://[YourDomain]/auth/google/redirect', 'Microsoft auth callback'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Update this to use a Microsoft-specific path, e.g., 'http://[YourDomain]/auth/microsoft/redirect'
Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
This pull request corrects the Microsoft auth callback URL in the self-hosting documentation for Twenty.
- Fixed
AUTH_MICROSOFT_CALLBACK_URL
in/packages/twenty-website/src/content/developers/self-hosting/self-hosting-var.mdx
to use '/auth/microsoft/redirect' instead of '/auth/google/redirect' - Ensures consistency between the documented callback URL and the actual implementation for Microsoft authentication
- Improves accuracy of self-hosting setup instructions for Microsoft OAuth integration
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Solves twentyhq#7442 Added callback url structure in google and microsoft auth for self hosting. ![374160284-da3f62d2-68b5-4e28-a038-819463c6ea46](https://github.com/user-attachments/assets/343943e9-033d-466d-8d68-1a7e7f6faf2e)
Solves #7442
Added callback url structure in google and microsoft auth for self hosting.