Fix issues with Apollo cache in workflow module #7569
Conversation
…ache has not been filled yet with other versions than the one deleted
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses Apollo cache synchronization issues in the workflow module, focusing on improving cache updates after mutations and enhancing UI consistency.
- Simplified cache update logic in
triggerDeleteRecordsOptimisticEffect.tsby removing unnecessary code and variables - Updated
useActivateWorkflowVersionhook to directly modify cache, updating activated version status and archiving other active versions - Modified
useDeactivateWorkflowVersionto usemodifyRecordFromCachefor direct cache updates instead of refetching data - Improved
useWorkflowWithCurrentVersionhook to better handle current workflow version selection, addressing active version handling issues - Updated
RecordShowPageWorkflowHeaderandRecordShowPageWorkflowVersionHeadercomponents to ensure proper cache updates after workflow operations
7 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile
| const activateWorkflowVersion = async ({ | ||
| workflowVersionId, | ||
| workflowId, | ||
| }: { | ||
| workflowVersionId: string; | ||
| workflowId: string; | ||
| }) => { |
There was a problem hiding this comment.
style: Consider adding a type definition for the function parameters
| for (const workflowVersion of allWorkflowVersions) { | ||
| apolloClient.cache.modify({ | ||
| id: apolloClient.cache.identify(workflowVersion), | ||
| fields: { | ||
| status: () => { | ||
| return workflowVersion.id !== workflowVersionId && | ||
| workflowVersion.status === 'ACTIVE' | ||
| ? 'ARCHIVED' | ||
| : workflowVersion.status; | ||
| }, | ||
| }, | ||
| }); | ||
| } |
There was a problem hiding this comment.
style: This loop modifies cache entries individually. Consider using a batch update if possible for better performance
| const apolloMetadataClient = useApolloMetadataClient(); | ||
| const apolloClient = useApolloClient(); |
There was a problem hiding this comment.
style: Consider moving these client initializations outside the hook for better performance
| const [mutate] = useMutation< | ||
| ActivateWorkflowVersionMutation, | ||
| ActivateWorkflowVersionMutationVariables | ||
| >(DEACTIVATE_WORKFLOW_VERSION, { | ||
| client: apolloMetadataClient ?? ({} as ApolloClient<any>), | ||
| }); |
There was a problem hiding this comment.
logic: The mutation type seems to be incorrect. It's using ActivateWorkflowVersionMutation for a deactivate operation
| recordId: workflowVersionId, | ||
| objectMetadataItem: objectMetadataItemWorkflowVersion, | ||
| fieldModifiers: { | ||
| status: () => 'DEACTIVATED', |
There was a problem hiding this comment.
style: Consider using an enum or constant for the status value
Fixes #7523