Fix zapier tests #7568
Fix zapier tests #7568
Conversation
martmull
force-pushed
the
fix-zapier-tests
branch
from
f0c0e74 to
7086178
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request updates the Zapier integration tests and related utilities, focusing on improved flexibility and support for new data structures in the Twenty CRM system.
- Modified
packages/twenty-zapier/src/test/authentication.test.tsto be less brittle by checking for a defined error message instead of a specific one - Updated
packages/twenty-zapier/src/test/creates/crud_record.test.tsto accommodate new data formats forlinkedinLink,xLink, andphonesfields - Added
listandplaceholderproperties inpackages/twenty-zapier/src/test/utils/computeInputFields.test.tsandpackages/twenty-zapier/src/utils/computeInputFields.ts - Removed test file exclusions in
packages/twenty-zapier/tsconfig.json, allowing TypeScript compilation of test files
5 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
| expect(response.data).toHaveProperty('currentWorkspace'); | ||
| expect(response.data.currentWorkspace).toHaveProperty('displayName'); |
There was a problem hiding this comment.
logic: These expectations are unreachable if an error is thrown. Consider moving them before the try-catch block or removing them.
| linkedinLink: { | ||
| primaryLinkUrl: '/linkedin_url', | ||
| primaryLinkLabel: 'Test linkedinUrl', | ||
| secondaryLinks: [ | ||
| '{ url: "/linkedin_url2", label: "Test linkedinUrl2" }', | ||
| ], | ||
| }, |
There was a problem hiding this comment.
logic: The secondaryLinks are stored as a string representation of an object, which may cause issues when parsing. Consider using a proper object structure instead of a string.
| xLink: { | ||
| primaryLinkUrl: '/x_url', | ||
| primaryLinkLabel: 'Test xUrl', | ||
| secondaryLinks: ['{ url: "/x_url2", label: "Test xUrl2" }'], | ||
| }, |
There was a problem hiding this comment.
logic: Similar to the linkedinLink, the xLink secondaryLinks are stored as a string. Ensure this is the intended format and that it can be properly parsed.
| phones: { | ||
| primaryPhoneNumber: '610203040', | ||
| primaryPhoneCountryCode: '+33', | ||
| additionalPhones: ['{number: "610203041", countryCode: "+33"}'], | ||
| }, |
There was a problem hiding this comment.
logic: The additionalPhones field is using a string representation of an object. This might cause parsing issues. Consider using a proper object structure.
See title
See title