Remove graphql twenty orm feature flag #7556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request removes the 'IS_QUERY_RUNNER_TWENTY_ORM_ENABLED' feature flag, which was fully launched in version 0.31.0, simplifying the codebase across multiple components and services.
- Removed 'IS_QUERY_RUNNER_TWENTY_ORM_ENABLED' flag from
/packages/twenty-server/src/database/typeorm-seeds/core/feature-flags.ts - Simplified resolver factories in
/packages/twenty-server/src/engine/api/graphql/workspace-resolver-builder/factories/by removing feature flag checks and directly using GraphqlQueryRunnerService - Updated
/packages/twenty-front/src/modules/command-menu/components/CommandMenu.tsxto remove 'isTwentyOrmEnabled' variable, simplifying search logic - Streamlined
/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/resolvers/graphql-query-search-resolver.service.tsby removing redundant feature flag check
12 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
170
to
+175
| const isWorkspaceMigratedForSearch = useIsFeatureEnabled( | ||
| 'IS_WORKSPACE_MIGRATED_FOR_SEARCH', | ||
| ); | ||
|
|
||
| const isSearchEnabled = | ||
| useIsFeatureEnabled('IS_SEARCH_ENABLED') && | ||
| isTwentyOrmEnabled && | ||
| isWorkspaceMigratedForSearch; | ||
| useIsFeatureEnabled('IS_SEARCH_ENABLED') && isWorkspaceMigratedForSearch; |
There was a problem hiding this comment.
logic: Search enablement now only depends on 'IS_SEARCH_ENABLED' and 'IS_WORKSPACE_MIGRATED_FOR_SEARCH'. Ensure this doesn't unintentionally enable search for environments where it shouldn't be.
charlesBochet
approved these changes
Oct 10, 2024
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
## Context IS_QUERY_RUNNER_TWENTY_ORM_ENABLED has been fully launched in 0.31.0, the feature flag can be safely removed. Note: Waiting for 0.31.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
IS_QUERY_RUNNER_TWENTY_ORM_ENABLED has been fully launched in 0.31.0, the feature flag can be safely removed.
Note: Waiting for 0.31.1