Fix workflow statuses #7555
Merged
Fix workflow statuses #7555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses workflow status issues and integrates workflow-related objects with timeline activities. Key changes include:
- Added event emission for created workflow versions in
workflow-create-many.post-query.hook.ts, fixing initial status setting - Introduced new
timelineActivitiesrelations to workflow-related entities (WorkflowRun, WorkflowVersion, Workflow) - Updated
standard-field-ids.tswith new IDs for workflow-related fields and timeline activities - Modified
WorkflowQueryHookModuleto includeWorkflowCreateOnePostQueryHookand necessary imports - Removed
@WorkspaceIsNullabledecorators from some relations inworkflow.workspace-entity.tsfor improved consistency
7 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
...wenty-server/src/modules/workflow/common/query-hooks/workflow-create-many.post-query.hook.ts
Show resolved
Hide resolved
.../twenty-server/src/modules/workflow/common/standard-objects/workflow-run.workspace-entity.ts
Show resolved
Hide resolved
...nty-server/src/modules/workflow/common/standard-objects/workflow-version.workspace-entity.ts
Show resolved
Hide resolved
...ages/twenty-server/src/modules/workflow/common/standard-objects/workflow.workspace-entity.ts
Show resolved
Hide resolved
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Event was not emitted after first version insertion. So initial status was not set. Also adding workflow related objects to timeline activities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event was not emitted after first version insertion. So initial status was not set.
Also adding workflow related objects to timeline activities.