Breadcrumb DropDown improvement #7546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request enhances the user experience in the field creation process for the data model settings, focusing on improved navigation and field type handling.
- Added field type handling in
SettingsDataModelNewFieldBreadcrumbDropDown.tsx, disabling the 'Configure' step when no field type is selected - Implemented setting of field type in form context when selected in
SettingsObjectNewFieldSelector.tsx - Modified navigation in
SettingsObjectNewFieldConfigure.tsxto preserve field type when canceling configuration - Improved overall user feedback and prevented invalid navigation states throughout the field creation flow
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
| const theme = useTheme(); | ||
|
|
||
| const fieldType = searchParams.get('fieldType') as SettingsFieldType; |
There was a problem hiding this comment.
style: Consider using a type guard or assertion function instead of type assertion
| const handleClick = (isConfigureStep: boolean) => { | ||
| if (isConfigureStep) { | ||
| navigate(`/settings/objects/${objectSlug}/new-field/configure`); | ||
| const handleClick = (step: 'select' | 'configure') => { |
There was a problem hiding this comment.
style: handleClick function could be simplified by using early returns
FelixMalfait
approved these changes
Oct 9, 2024
...t/src/modules/settings/data-model/components/SettingsDataModelNewFieldBreadcrumbDropDown.tsx
Outdated
Show resolved
Hide resolved
|
Thanks @ehconitin for your contribution! |
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
context - twentyhq#7397 (review) P.S. Apologies for the background music in the screen recording—I didn’t realize my mic was on while capturing it. 😅 https://github.com/user-attachments/assets/0cd31aa7-9ce2-4577-a79a-73c9890f2905 --------- Co-authored-by: Félix Malfait <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context - #7397 (review)
P.S. Apologies for the background music in the screen recording—I didn’t realize my mic was on while capturing it. 😅
2024-10-09.23-55-08.mov