Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add margin bottom to all navigation drawer items #7544

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Add margin bottom to all navigation drawer items #7544

merged 1 commit into from
Oct 9, 2024

Conversation

thomtrp
Copy link
Contributor

@thomtrp thomtrp commented Oct 9, 2024

Capture d’écran 2024-10-09 à 15 43 39 Capture d’écran 2024-10-09 à 15 43 49

greptile-apps[bot]
greptile-apps bot reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR modifies the navigation drawer sections to add consistent spacing between items, improving the overall layout and readability of the settings menu.

  • Replaced StyledNavigationDrawerSection with NavigationDrawerSection in packages/twenty-front/src/modules/settings/components/SettingsNavigationDrawerItems.tsx
  • Added margin-bottom: ${({ theme }) => theme.spacing(3)}; to NavigationDrawerSection in packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawerSection.tsx
  • These changes ensure uniform spacing between navigation sections, enhancing visual consistency

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings

...nty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawerSection.tsx
@@ -5,6 +5,7 @@ const StyledSection = styled.div`
flex-direction: column;
gap: ${({ theme }) => theme.betweenSiblingsGap};
width: 100%;
margin-bottom: ${({ theme }) => theme.spacing(3)};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider if this margin is necessary for all sections, or if it should be applied conditionally.

@thomtrp thomtrp merged commit 10fa6e1 into main Oct 9, 2024
13 of 14 checks passed
@thomtrp thomtrp deleted the tt-fix-margin-bottom-on-all-navigation-sections branch October 9, 2024 14:20
harshit078 pushed a commit to harshit078/twenty that referenced this pull request Oct 14, 2024
@thomtrp @harshit078
Add margin bottom to all navigation drawer items (twentyhq#7544)
2c117fd 
<img width="259" alt="Capture d’écran 2024-10-09 à 15 43 39"
src="https://github.com/user-attachments/assets/4ddf2ca6-73a6-4d18-9ec6-83b30d66514f">
<img width="259" alt="Capture d’écran 2024-10-09 à 15 43 49"
src="https://github.com/user-attachments/assets/a2c82fba-954a-4104-9a83-427d11644567">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@charlesBochet charlesBochet charlesBochet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomtrp @charlesBochet